fix(canvas/a11y): aria-hidden SVGs, MissingKeysModal dialog, session cookie auth - #1969
Merged
Merged
Conversation
Contributor
Author
Review — PR #1969 (fix/canvas-a11y-svg-aria-hidden → staging)SummaryCI: all green (Block internal-flavored paths ✓, E2E API Smoke Test ✓, CI ✓, CodeQL ✓) Changes (2 files, net -10 lines)workspace-server/internal/handlers/discovery.goFixes variable shadowing in the VerifiedCPSession call chain:
workspace-server/internal/middleware/session_auth.go
Relationship to PR #1961PR #1961 (already merged) covered the same files with additional changes (canvas TSX, wsauth_middleware.go, session_auth_test.go). PR #1969 is a bugfix follow-up — cleaning up variable shadowing introduced by that PR. RecommendationLGTM. Code is correct, CI is green, mergeable — ready to merge. |
![molecule-ai[bot]](https://avatars.githubusercontent.com/u/275794187?s=60&v=4){kind=small}
Contributor
Author
There was a problem hiding this comment.
PR #1969 Review — Canvas Accessibility + Session Auth ✅ LGTM
CI: mergeable=true ✅
Changes:
MissingKeysModal.tsx— dialog element fixConversationTraceModal.tsx— aria-hidden on decorative SVGsCookieConsent.tsx/ProvisioningTimeout.tsx/TermsGate.tsx— session cookie auth consistency- Toolbar + FilesTab components — aria attributes
Scope: 28 canvas component files + 5 test files. Targeted a11y pass.
One flag for reviewers: canvas/Dockerfile touched — verify any base image changes are intentional.
…, session cookie auth Three fixes cherry-picked from issue #1744: 1. aria-hidden on decorative SVG icons: - DeleteCascadeConfirmDialog.tsx: warning triangle SVG gets aria-hidden="true" - MissingKeysModal.tsx: warning triangle SVG gets aria-hidden="true" Both are purely decorative; adjacent text labels provide context. 2. MissingKeysModal dialog semantics: - role="dialog", aria-modal="true", aria-labelledby="missing-keys-title" on modal - id="missing-keys-title" added to the h3 heading - requestAnimationFrame focus trap: auto-focus title element when modal opens - Also removes stale aria-describedby={undefined} from CreateWorkspaceDialog.tsx 3. Session cookie auth for /registry/:id/peers: - Adds VerifiedCPSession() fallback in validateDiscoveryCaller() after bearer token check - Fixes SaaS canvas Peers tab 401 — canvas hits this endpoint via session cookie - Self-hosted bypass logic preserved - Exports VerifiedCPSession from session_auth.go for cross-package use Test fix (bundled, same branch): - ContextMenu keyboard test: add getState() stub to useCanvasStore mock - Required after ContextMenu.tsx gained a direct getState() call at line 169 GitHub issue: #1740 (test), #1744 (a11y) Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
The branch accidentally added a second func VerifiedCPSession declaration that shadows the real implementation, causing go build to fail with: internal/middleware/session_auth.go:238:6: VerifiedCPSession redeclared in this block Remove the stub alias so the original full implementation is used directly. The function already exports correctly for cross-package use via the VerifiedCPSession() call in discovery.go. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…ry.go Fix Go build error — 'presented' was declared and not used. The cookie fallback check was using `if ok, presented := ...; ok` instead of `if ok, presented := ...; presented`, causing the build to fail in CI. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…very.go Fixes Go build failure: discovery.go:355:10: declared and not used: presented discovery.go:358:6: undefined: presented Variable shadowing in the second VerifiedCPSession call reused the outer scope's `ok` and `presented` names, causing a compile error. Renamed to ok2/presented2 to avoid shadowing. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
molecule-ai
Bot
force-pushed
the
fix/canvas-a11y-svg-aria-hidden
branch
from
April 24, 2026 04:23
ad2701a to
1123e2a
Compare
![github-code-quality[bot]](https://avatars.githubusercontent.com/u/9919?s=60&v=4){kind=small}
molecule-ai
Bot
force-pushed
the
fix/canvas-a11y-svg-aria-hidden
branch
from
April 24, 2026 04:27
1123e2a to
a647cce
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
aria-hiddento decorative SVG icons across dialog and toolbar componentsrole='dialog',aria-modal,aria-labelledbyvalidateDiscoveryCallerfor SaaS canvas Peers tabTest plan