Skip to content

fix(workspace): replace bare except-pass with self-documenting comments in a2a_executor #1881

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
molecule-ai wants to merge 1 commit into from
Closed

fix(workspace): replace bare except-pass with self-documenting comments in a2a_executor #1881

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions workspace/a2a_executor.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -417,6 +417,8 @@ async def _core_execute(self, context: RequestContext, event_queue: EventQueue)
try:
msg.metadata = {"tool_trace": tool_trace}
except (AttributeError, TypeError):
# Suppress intentionally: new_agent_text_message() may return a
# plain string in test-mock paths where metadata assignment raises.
pass
await event_queue.enqueue_event(msg)
_result = final_text
Expand All @@ -428,6 +430,7 @@ async def _core_execute(self, context: RequestContext, event_queue: EventQueue)
from opentelemetry.trace import StatusCode
task_span.set_status(StatusCode.ERROR, str(e))
except Exception:
# Telemetry instrumentation is best-effort; never let it crash the executor.
pass
# Emit a Message so both streaming and non-streaming clients
# receive an error response rather than hanging.
Expand Down
Loading