Skip to content

fix(handlers): add CanCommunicate hierarchy check to terminal WebSocket handler (KI-005) #1809

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
molecule-ai wants to merge 1 commit into from
Closed

fix(handlers): add CanCommunicate hierarchy check to terminal WebSocket handler (KI-005) #1809

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 27 additions & 0 deletions workspace-server/internal/handlers/terminal.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,8 @@ import (

"github.com/Molecule-AI/molecule-monorepo/platform/internal/db"
"github.com/Molecule-AI/molecule-monorepo/platform/internal/provisioner"
"github.com/Molecule-AI/molecule-monorepo/platform/internal/registry"
"github.com/Molecule-AI/molecule-monorepo/platform/internal/wsauth"
"github.com/creack/pty"
"github.com/docker/docker/api/types"
"github.com/docker/docker/api/types/container"
Expand All @@ -25,6 +27,11 @@ import (

const terminalSessionTimeout = 30 * time.Minute

// canCommunicateCheck is the communication-authorization predicate used by
// HandleConnect to enforce the KI-005 workspace-hierarchy guard.
// Exposed as a package var so tests can stub it without DB fixtures.
var canCommunicateCheck = registry.CanCommunicate

var termUpgrader = websocket.Upgrader{
CheckOrigin: func(r *http.Request) bool {
origin := r.Header.Get("Origin")
Expand Down Expand Up @@ -60,6 +67,26 @@ func (h *TerminalHandler) HandleConnect(c *gin.Context) {
workspaceID := c.Param("id")
ctx := c.Request.Context()

// KI-005: enforce CanCommunicate hierarchy check before granting terminal
// access. WorkspaceAuth validates the bearer's token, but the token is
// scoped to a specific workspace ID — Workspace A's token can reach
// Workspace A's terminal. Without CanCommunicate, Workspace A could also
// reach Workspace B's terminal if it knows B's UUID (enumeration via
// canvas, logs, or delegation). Shell access is more dangerous than A2A
// message-passing, so we apply the same hierarchy check here.
callerID := c.GetHeader("X-Workspace-ID")
if callerID != "" {
tok := wsauth.BearerTokenFromHeader(c.GetHeader("Authorization"))
if tok != "" {
if err := wsauth.ValidateAnyToken(ctx, db.DB, tok); err == nil {
if !canCommunicateCheck(callerID, workspaceID) {
c.JSON(http.StatusForbidden, gin.H{"error": "not authorized to access this workspace's terminal"})
return
}
}
}
}

// Check for CP-provisioned workspace (instance_id persisted by
// provisionWorkspaceCP → migration 038). Null instance_id means the
// workspace runs as a local Docker container on this tenant.
Expand Down
Loading