fix(core): consolidate 3 security fixes from PRs #1470 #1474 - #1486
Closed
molecule-ai[bot] wants to merge 2 commits into
Closed
molecule-ai[bot] wants to merge 2 commits into
molecule-ai[bot] wants to merge 2 commits into
Conversation
- CWE-22 (F1434): copyFilesToContainer uses cleaned path in Join + defense-in-depth guard - CWE-78 (F1085): deleteViaEphemeral rm arg scoped to /configs/ + validateRelPath - SSRF dedup: mcp_tools.go removes net/url imports (helpers now in a2a_proxy.go) - Add container_files_test.go: 85-line CWE-22/CWE-78 regression suite Co-authored-by: DevOps Bot <devops-bot@molecule.ai>
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Consolidates 3 security fixes from stalled PRs into a clean branch from staging.
copyFilesToContaineruses cleaned path inJoinwith defense-in-depth prefix guard (staging 42bc14e)deleteViaEphemeralrm arg scoped to/configs/+validateRelPathguardmcp_tools.goremovesnet/url/SSRF helpers now ina2a_proxy.go(consistent with staging)Testing
container_files_test.go: 85-line regression suite covering CWE-22/CWE-78 path traversal and rm argument scopingWhy this PR
PRs #1460 and #1472 stuck in CI queue with cancelled runs. Branch created fresh from staging for clean CI run.
🤖 Generated with Claude Code