Skip to content

fix(core): resolve main build — remove duplicate SSRF function declarations #1469

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
molecule-ai merged 1 commit into from
Apr 21, 2026
Merged

fix(core): resolve main build — remove duplicate SSRF function declarations #1469

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion workspace-server/internal/handlers/a2a_proxy.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@ import (
"database/sql"
"encoding/json"
"errors"
"fmt"
"io"
"log"
"net"
Expand Down
90 changes: 0 additions & 90 deletions workspace-server/internal/handlers/ssrf.go
View file
Open in desktop

This file was deleted.

8 changes: 6 additions & 2 deletions workspace-server/internal/handlers/ssrf_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,8 @@ import (
"testing"
)

// isSafeURL is defined in mcp.go.
// isPrivateOrMetadataIP is defined in mcp.go.
// isSafeURL is defined in a2a_proxy.go.
// isPrivateOrMetadataIP is defined in a2a_proxy.go.
// saasMode is defined in registry.go.

// TestSaasMode covers the env-resolution ladder so a self-hosted
Expand Down Expand Up @@ -127,6 +127,8 @@ func TestIsPrivateOrMetadataIP_IPv6(t *testing.T) {
}

func TestIsPrivateOrMetadataIP(t *testing.T) {
t.Setenv("MOLECULE_DEPLOY_MODE", "")
t.Setenv("MOLECULE_ORG_ID", "")
cases := []struct {
name string
ipStr string
Expand Down Expand Up @@ -173,6 +175,8 @@ func TestIsPrivateOrMetadataIP(t *testing.T) {
}

func TestIsSafeURL(t *testing.T) {
t.Setenv("MOLECULE_DEPLOY_MODE", "")
t.Setenv("MOLECULE_ORG_ID", "")
cases := []struct {
name string
rawURL string
Expand Down
Loading