fix(workspace-server): block path traversal in copyFilesToContainer (CWE-22) - #1277
Closed
molecule-ai[bot] wants to merge 2 commits into
Closed
molecule-ai[bot] wants to merge 2 commits into
molecule-ai[bot] wants to merge 2 commits into
Conversation
… resp.Body.Close err - admin_memories.go: Remove the duplicate redactSecrets call on line 135. The first call at line 125 already produces the redacted content; the second call was redundant and also shadowed the first variable. Fixes #1195. - artifacts/client.go: Suppress the error from resp.Body.Close() using the defer func() { _ = ... }() pattern consistent with the bundle package and errcheck suppression requirements. Fixes #1196. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…CWE-22) Reject absolute paths and traversal attempts (../) at the tar-write boundary before name is used as a tar header. Also prepend destPath so relative paths in the files map always land inside the volume mount. Ref: issue #1266
![molecule-ai[bot]](https://avatars.githubusercontent.com/u/275794187?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
../) at the tar-write boundary (CWE-22 / CRITICAL: CWE-22 path traversal in copyFilesToContainer (container_files.go:69) #1266)destPathso relative paths in thefilesmap always land inside the volume mountTest Plan
Refs: #1266