Use source as the dst for go-getter #9
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
An md5 hash of the dst is used as the folder name on disk. In hashicorp#1418 this was altered to not be platform specific. The dst was changed from the source to a key based on the module path. This was done so that terraform push would work. This had the side affect that modules with the same source would result in multiple downloads. This was acknowledged in the original commit. This is a simple way to have the key be based on source again. Tested with terraform get and all works ok. With terraform get --update the update is done multiple times as if the 1:1 mapping was still in place.
|
SGTM |
|
this'll need to be updated onto |
|
Yeh I definitely think we should be advocating a change to upstream. This wouldn't be the change I'd recommend though as this reverts something that was deliberately decided. I'm going to close this and branch off our latest. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An md5 hash of the dst is used as the folder name on disk.
In hashicorp#1418 this was altered
to not be platform specific. The dst was changed from the source to a
key based on the module path. This was done so that terraform push
would work. This had the side affect that modules with the same source
would result in multiple downloads. This was acknowledged in the original
commit.
This is a simple way to have the key be based on source again.
Tested with terraform get and all works ok. With terraform get --update
the update is done multiple times as if the 1:1 mapping was still in
place.