Skip to content

[backport] Fixes for flaky WPF test (#3784)#57

Merged
redvinaa merged 1 commit intohumblefrom
fix-error-code-clearing
Apr 3, 2025
Merged

[backport] Fixes for flaky WPF test (#3784)#57
redvinaa merged 1 commit intohumblefrom
fix-error-code-clearing

Conversation

@RBT22
Copy link

@RBT22 RBT22 commented Apr 3, 2025

  • Fixes for flaky WPF test:

  • New RewrittenYaml ability to add non-existing parameters

  • Prune distance fix for WPF test

  • Treat UNKNOWN status as error in WPF

  • Clear error codes after BT run

  • Remove unnecessary setInitialPose() from WPF test

  • Update nav2_waypoint_follower/src/waypoint_follower.cpp

  • Clean error code in any situation

  • Fix UNKNOWN WPF status handling



Basic Info

Info Please fill out this column
Ticket(s) this addresses (add tickets here #1)
Primary OS tested on (Ubuntu, MacOS, Windows)
Robotic platform tested on (Steve's Robot, gazebo simulation of Tally, hardware turtlebot)

Description of contribution in a few bullet points

Description of documentation updates required from your changes


Future work that may be required in bullet points

For Maintainers:

  • Check that any new parameters added are updated in navigation.ros.org
  • Check that any significant change is added to the migration guide
  • Check that any new features OR changes to existing behaviors are reflected in the tuning guide
  • Check that any new functions have Doxygen added
  • Check that any new features have test coverage
  • Check that any new plugins is added to the plugins page
  • If BT Node, Additionally: add to BT's XML index of nodes for groot, BT package's readme table, and BT library lists

* Fixes for flaky WPF test:
* New RewrittenYaml ability to add non-existing parameters
* Prune distance fix for WPF test
* Treat UNKNOWN status as error in WPF
* Clear error codes after BT run
* Remove unnecessary setInitialPose() from WPF test

* Update nav2_waypoint_follower/src/waypoint_follower.cpp

Co-authored-by: Steve Macenski <stevenmacenski@gmail.com>

* Clean error code in any situation

* Fix UNKNOWN WPF status handling

---------

Co-authored-by: Steve Macenski <stevenmacenski@gmail.com>
@redvinaa redvinaa merged commit 6eed6b2 into humble Apr 3, 2025
@RBT22 RBT22 deleted the fix-error-code-clearing branch September 11, 2025 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants