Skip to content

[backport] [RotationShimController] fix: rotate on short paths (#4716)#54

Closed
RBT22 wants to merge 1 commit intohumblefrom
fix-shim-short-paths
Closed

[backport] [RotationShimController] fix: rotate on short paths (#4716)#54
RBT22 wants to merge 1 commit intohumblefrom
fix-shim-short-paths

Conversation

@RBT22
Copy link

@RBT22 RBT22 commented Feb 12, 2025

Add header data to goal for short paths.

Commit d8ae3c1 added the possibility to the rotation shim controller to rotate towards the goal when the goal was closer that the forward_sampling_distance. This feature was not fully working as the goal was missing proper header data, causing the rotation shim to give back control to the main controller.


Basic Info

Info Please fill out this column
Ticket(s) this addresses (add tickets here #1)
Primary OS tested on (Ubuntu, MacOS, Windows)
Robotic platform tested on (Steve's Robot, gazebo simulation of Tally, hardware turtlebot)

Description of contribution in a few bullet points

Description of documentation updates required from your changes


Future work that may be required in bullet points

For Maintainers:

  • Check that any new parameters added are updated in navigation.ros.org
  • Check that any significant change is added to the migration guide
  • Check that any new features OR changes to existing behaviors are reflected in the tuning guide
  • Check that any new functions have Doxygen added
  • Check that any new features have test coverage
  • Check that any new plugins is added to the plugins page
  • If BT Node, Additionally: add to BT's XML index of nodes for groot, BT package's readme table, and BT library lists

)

Add header data to goal for short paths.

Commit d8ae3c1 added the possibility to
the rotation shim controller to rotate towards the goal when the goal
was closer that the `forward_sampling_distance`. This feature was not
fully working as the goal was missing proper header data, causing the
rotation shim to give back control to the main controller.

Co-authored-by: agennart <antoine.gennart@quimesis.be>
@emilnovak
Copy link

This may cause some behavioral changes when we update to jazzy. Decided that the current problem (short path is using MPPI for rotation) is not solved by this.

@emilnovak emilnovak closed this Mar 3, 2025
@emilnovak emilnovak deleted the fix-shim-short-paths branch March 3, 2025 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants