Skip to content

Backport duration int to double (#3871)#30

Merged
redvinaa merged 1 commit intohumblefrom
backport-duration
Oct 30, 2024
Merged

Backport duration int to double (#3871)#30
redvinaa merged 1 commit intohumblefrom
backport-duration

Conversation

@turtlewizard73
Copy link

backport ros-navigation@63fc6a1

  • change duration tyype from int to double

  • change "1" to "1.0" as default wait_duration value

  • modify wait_action tests

  • fix

  • change int values to double in trees

  • add usage of Duration::from_seconds()

  • fix build failing issue

  • delete whitespace


Basic Info

Info Please fill out this column
Ticket(s) this addresses (add tickets here #1)
Primary OS tested on (Ubuntu, MacOS, Windows)
Robotic platform tested on (Steve's Robot, gazebo simulation of Tally, hardware turtlebot)

Description of contribution in a few bullet points

Description of documentation updates required from your changes


Future work that may be required in bullet points

For Maintainers:

  • Check that any new parameters added are updated in navigation.ros.org
  • Check that any significant change is added to the migration guide
  • Check that any new features OR changes to existing behaviors are reflected in the tuning guide
  • Check that any new functions have Doxygen added
  • Check that any new features have test coverage
  • Check that any new plugins is added to the plugins page
  • If BT Node, Additionally: add to BT's XML index of nodes for groot, BT package's readme table, and BT library lists

…gation#3871)

* change duration tyype from int to double

* change "1" to "1.0" as default wait_duration value

* modify wait_action tests

* fix

* change int values to double in trees

* add usage of Duration::from_seconds()

* fix build failing issue

* delete whitespace
@turtlewizard73 turtlewizard73 changed the title In wait_action node change duration type from int to double (#3871) Backport duration int to double (#3871) Oct 28, 2024
@redvinaa redvinaa merged commit 756a9eb into humble Oct 30, 2024
@RBT22 RBT22 deleted the backport-duration branch November 6, 2024 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants