BT nodes not able to accept parameter values (#3988)#29
Closed
Conversation
* fix simple cases * fix on_tick type in drive_on_heading node * fix linting and fixed other nodes * Revert "fix linting and fixed other nodes" This reverts commit c1cd575. * fix linting * fixes for subscription cases in action nodes * fixes in condition nodes * fix input usage * fix uncrustify * . * fix typo in back_up_action.cpp * fix in drive_on_heading_action * remove unnecessary first_use variables * typo * typo * typo * fixed typos * move initialize() method above tick() * revert changes in truncate_path_action node * revert changes in case of creating subscription in constructor * remove global_frame_ in remove_passed_goals_action node * changes in is_path_valid and rate_controller nodes * change bt_cancel_action node * change bt_action_node * add xml_tag parameter * revert changes in bt_action and bt_cancel_action nodes * pre-commit * .
Collaborator
|
The problem with this is that IDLE (aka first tick since last halted) is not the same as initialized == false (aka first tick since construction). And if we load the blackboard from the navigator at the start of every new task (which we do), it could cause problems. Specifically if these values change between task calls, like they do for executing_sound. It works now because we call getInput on every tick, but in other cases it could cause problems. |
Author
|
Closing in favor of #33 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport ros-navigation#3988