Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Custom GitHub Actions #7

Merged
merged 123 commits into from
Jul 18, 2022
Merged

Implement Custom GitHub Actions #7

merged 123 commits into from
Jul 18, 2022

Conversation

EngineerDanny
Copy link
Owner

@EngineerDanny EngineerDanny commented Jun 30, 2022

This PR intends to create Github Actions to make it easier for package developers to use Rperform to test their code.
The Actions are tested on a separate repository stringr.

@EngineerDanny
Copy link
Owner Author

EngineerDanny commented Jul 1, 2022

The Github workflow directory, which is the .github/workflow/ directory, is created automatically when you ran
Rperform::init_rperform() function. It is also populated with the needed workflow files to be able to run Rperform with ease. It also adds the rperform directory and populates it with files which make test configuration and customisation easier. One of the most important files in that directory is the script.R file which is where the Rperform test functions should be written.
Screenshot 2022-07-01 at 3 33 40 PM
This is still work in progress. For now, I only tested it with the plot_metrics. More updates will follow.

@EngineerDanny EngineerDanny added the enhancement New feature or request label Jul 1, 2022
@EngineerDanny EngineerDanny self-assigned this Jul 1, 2022
@EngineerDanny
Copy link
Owner Author

EngineerDanny commented Jul 1, 2022

I had an issue with the Github create comment script which was similar to this issue. After several debugging and testing, I have been able to successfully automate the creation of comments. (Auto Comment On PR).
Testing results are firstly uploaded as an artifact on Github.
Then afterwards, a comment is created by Github actions bot on the PR.

@EngineerDanny
Copy link
Owner Author

EngineerDanny commented Jul 1, 2022

Another minor update is that this PR addresses is the x-axis theme. Now, it is diagonal (-45°) instead of straight vertical(-90°).

Screenshot 2022-07-01 at 10 06 46 PM

@tdhock
Copy link
Collaborator

tdhock commented Jul 13, 2022

can you please share what the updated plots/results would look like for the user?

@EngineerDanny
Copy link
Owner Author

@tdhock Yes. This is an example comment.
It is very much customisable. I included header.R and footer.R files which the user can customise to edit the general comment output.

@EngineerDanny
Copy link
Owner Author

EngineerDanny commented Jul 14, 2022

@tdhock Great feedback. Since all the comments you raised target mostly the ggplot graph output, I am going to close this PR and proceed with submitting another PRs to fix them accordingly.

@tdhock
Copy link
Collaborator

tdhock commented Jul 14, 2022

great

@EngineerDanny EngineerDanny merged commit 3e9cd92 into master Jul 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants