Revise association maximum PDU length handling#689
Merged
Conversation
Enet4
added
enhancement
breaking change
- remove MAXIMUM_PDU_LENGTH and lift any limits to this property - allocate write buffers at start with capacity DEFAULT_PDU_LENGTH - adjust more capacity allocations so that they are capped by an internal constant 2621444 - fix max PDU length admitted in `ClientAssociation::receive` (sync and async versions)
Enet4
force-pushed
the
change/ul/no-pdu-max-length
branch
from
6292755 to
2abb0d8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
MAXIMUM_PDU_LENGTHand lift any limits to this property (affects alsofindscu,scpproxy,storescp, andstorescu), enabling compatible AEs to exchange larger PDUsDEFAULT_PDU_LENGTHLARGE_PDU_SIZE, or value 2621444, following the local max PDU length most of the time.ClientAssociation::receive(sync and async versions), should make Fix a pair of related bugs in Server/ClientAssociation::receive #686 obsoletereadermodule