Change PDU association variants and association types #345
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
Enet4
commented
May 7, 2023
Enet4
commented
- Use subtypes to describe PDU association variants
- Change client/server error types to have a smaller size and use new public types
Enet4
added
breaking change
Enet4
changed the title
- (breaking change) - make `AssociationRQ`, `AssociationAC`, and `AssociationRJ` types fully public - use subtypes in `Pdu` variants - propagate changes
- (breaking change) - add backtrace or add #[snafu(backtrace)] where missing - box Pdu values - replace client::Error::Rejected fields
Enet4
force-pushed
the
change/ul/pdu-types
branch
from
7973d4a
to
ce3e742
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.