Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove other references to SGI #394

Merged
merged 3 commits into from
Jul 3, 2024
Merged

Remove other references to SGI #394

merged 3 commits into from
Jul 3, 2024

Conversation

alexdewar
Copy link
Collaborator

I noticed that there's still a reference to SGI in the copyright notice (you can see it in the footer of the documentation). I've updated the copyright owner to be "Imperial College London" and I changed the year while I was at it.

There was also a reference to SGI in CITATION.cff -- I think it refers to the old GitHub org, but I don't think that's needed: https://docs.github.com/en/repositories/managing-your-repositorys-settings-and-features/customizing-your-repository/about-citation-files

FYI @ahawkes

@alexdewar alexdewar changed the title Update copyright owner and year Remove other references to SGI Jul 2, 2024
@alexdewar
Copy link
Collaborator Author

I've also just noticed that the version number in CITATION.cff is out of date... shall I fix it and add it to the list in .bumpversion.cfg?

@alexdewar alexdewar requested review from dalonsoa and tsmbland July 2, 2024 14:44
Copy link

codecov bot commented Jul 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.34%. Comparing base (5dfbb31) to head (11f3347).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #394   +/-   ##
========================================
  Coverage    71.34%   71.34%           
========================================
  Files           44       44           
  Lines         5916     5916           
  Branches      1168     1168           
========================================
  Hits          4221     4221           
  Misses        1373     1373           
  Partials       322      322           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@alexdewar
Copy link
Collaborator Author

alexdewar commented Jul 3, 2024

I've also just noticed this URL in pyproject.toml: http://www.sustainablegasinstitute.org/home/muse-energy-model/

If you try to go there, you get a 403 error.

Maybe we should send users here instead: https://www.imperial.ac.uk/muse-energy/what-is-muse-/

@alexdewar
Copy link
Collaborator Author

(Pinging @ahawkes re the URL -- this isn't urgent though)

@ahawkes
Copy link
Collaborator

ahawkes commented Jul 3, 2024 via email

@alexdewar
Copy link
Collaborator Author

Ok cool. I'll update it then.

Oddly, this Homepage field doesn't seem to be picked up by pip (even though I think we've done it correctly): pypa/packaging-problems#606

But I think that's a problem for another day...

@alexdewar alexdewar force-pushed the remove_ref_to_sgi branch from 0ce4c8f to 11f3347 Compare July 3, 2024 16:36
@alexdewar alexdewar enabled auto-merge July 3, 2024 16:37
@alexdewar alexdewar merged commit 36f8c77 into develop Jul 3, 2024
16 checks passed
@alexdewar alexdewar deleted the remove_ref_to_sgi branch July 3, 2024 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants