Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: sass config #1471

Closed
wants to merge 2 commits into from
Closed

Conversation

tomleo
Copy link
Member

@tomleo tomleo commented Aug 12, 2024

πŸ”— Linked issue

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

  • Update vite to 5.4.0 which fixes a bug via vitejs/vite@1025bb6 allowing hooks into the dart-sass API to silence deprecation warnings
  • Update to silence deprecation warnings (also applied to es-bs-base)
  • Made sure we're using the same version of SASS in es-bs-base and es-ds-docs

πŸ₯Ό Testing

🧐 Feedback Requested / Focus Areas

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.
  • I have documented testing approach

@tomleo tomleo changed the base branch from main to esds-3.0-vue3-primevue August 12, 2024 16:23
Copy link
Collaborator

@nathanielwarner nathanielwarner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should try fixing the deprecation warnings before we silence them. If we ignore them, the behavior will change in a future version of sass.

@tomleo
Copy link
Member Author

tomleo commented Aug 12, 2024

I think we should try fixing the deprecation warnings before we silence them. If we ignore them, the behavior will change in a future version of sass.

The particular warning being silenced was

175 β”‚ β”Œ           > .container#{breakpoints.breakpoint-infix($size, variables.$container-max-widths)} {
176 β”‚ β”‚             @extend %container-navbar-expand-#{$breakpoint};
177 β”‚ β”‚           }
    β”‚ └─── nested rule
... β”‚
183 β”‚           justify-content: flex-start;
    β”‚           ^^^^^^^^^^^^^^^^^^^^^^^^^^^ declaration
    β•΅
    ../es-bs-base/scss/_navbar.scss 183:9             @content
    ../es-bs-base/scss/mixins/_breakpoints.scss 69:5  media-breakpoint-up()
    ../es-bs-base/scss/_navbar.scss 181:7             @use
    ../es-bs-base/scss/bootstrap.scss 27:1            root stylesheet

@nathanielwarner
Copy link
Collaborator

I think we should try fixing the deprecation warnings before we silence them. If we ignore them, the behavior will change in a future version of sass.

The particular warning being silenced was

175 β”‚ β”Œ           > .container#{breakpoints.breakpoint-infix($size, variables.$container-max-widths)} {
176 β”‚ β”‚             @extend %container-navbar-expand-#{$breakpoint};
177 β”‚ β”‚           }
    β”‚ └─── nested rule
... β”‚
183 β”‚           justify-content: flex-start;
    β”‚           ^^^^^^^^^^^^^^^^^^^^^^^^^^^ declaration
    β•΅
    ../es-bs-base/scss/_navbar.scss 183:9             @content
    ../es-bs-base/scss/mixins/_breakpoints.scss 69:5  media-breakpoint-up()
    ../es-bs-base/scss/_navbar.scss 181:7             @use
    ../es-bs-base/scss/bootstrap.scss 27:1            root stylesheet

That's correct yeah. This is the issue in question I think we should try to address. It just involves moving the declaration above the nested rule for each of the 6 instances

@tomleo tomleo mentioned this pull request Aug 14, 2024
8 tasks
@tomleo tomleo closed this Aug 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants