-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(dh): adjustments to settlement report #3846
Conversation
View your CI Pipeline Execution ↗ for commit 3bc2f08.
☁️ Nx Cloud last updated this comment at |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggestion: I would not add the grid area query to shared. I think it was a mistake to move the queries away from where they are used. Better to have more specific query closer to the there are used, IMO.
Placing the query under Settlement reports now makes sense but it's also going to be used in Calculations very soon. In this case "Settlement reports" is not the best place anymore. Maybe "wholesale/data-access-graphql" makes more sense. |
I would have two query with the same content, but with different names. ex. GetGridAreasForSettlementReports and GetGridAreasForCalculations. Then dont the road if new fields a are added to only one of them, it do not over fetch data in the other because they are separated |
Interesting. Will need to think about it because the query right now is only used in a util function that maps the result to dropdown options. The function can of course be modified to take the query document as an input. |
Description
DataHub
References