Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added More Struct Info #11

Merged
merged 5 commits into from
May 24, 2024
Merged

Conversation

SaturnRoccat
Copy link
Contributor

thought id take a little time and label members in some classes
Affected Classes Were

  1. HashedString: Changed Unkown to mLastMatch and set the type to a const HashedString*
  2. MultiplayerServiceObserver: Changed Unknown to mpSubject and added comments to hint at type
  3. XboxLiveUserObserver: Changed Unkown to mpSubject and added comments to hint at type
  4. CommandOriginIdentity: Changed Unknown1 to mXuid changed Unknown2 to mPlatformOnlineId
  5. Packet

New Packet Structure:

class Packet {
public:
    virtual ~Packet() = default;

private:
    PacketPriority mPriority;                           // + 8
    NetworkPeer::Reliability mReliability;              // + 12
    SubClientId mSubClientId;                           // + 16
    bool mIsHandled;                                    // + 17  
    NetworkPeer::PacketRecvTimepoint mReceiveTimepoint; // + 24
    void* mHandler;                                     // + 32
    Compressibility mCompressible;                      // + 40
};  

Old Packet Structure:

class Packet {
public:
    virtual ~Packet() = default;

private:
    int unknown1_{2};           // +8
    int unknown2_{1};           // +12
    int unknown3_{0};           // +16
    std::int64_t unknown4_{0};  // +24
    std::int64_t unknown5_{0};  // +32
    int unknown6_{0};           // +40
};  

New Types:

  1. PacketPriority
  2. NetworkPeer
  3. NetworkPeer::Reliability
  4. NetworkPeer::PacketRecvTimepoint
  5. Compressibility

@wu-vincent
Copy link
Member

Great stuff! Thank you!

@SaturnRoccat
Copy link
Contributor Author

no problem. Wanted to do more but ran outta time

Copy link

codecov bot commented May 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 12.99%. Comparing base (d70fa6f) to head (48abed5).

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #11   +/-   ##
=======================================
  Coverage   12.99%   12.99%           
=======================================
  Files          27       27           
  Lines        1439     1439           
  Branches      643      643           
=======================================
  Hits          187      187           
  Misses       1093     1093           
  Partials      159      159           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants