Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: read/search PDF contents as well #63

Closed
cliffordx opened this issue Nov 12, 2022 · 4 comments
Closed

Feature Request: read/search PDF contents as well #63

cliffordx opened this issue Nov 12, 2022 · 4 comments

Comments

@cliffordx
Copy link

I suggest a feature to read/search PDF contents as well? or is this too much to ask for as a feature. Thanks!

@Endle Endle changed the title Feature Request Feature Request: read/search PDF contents as well Nov 12, 2022
@Endle
Copy link
Owner

Endle commented Nov 12, 2022

Sounds interesting.
How about: if a page has a link to a pdf file, then try to add all the information into this page?

I'll have a look on it, and check how hard it is.

@cliffordx
Copy link
Author

How about: if a page has a link to a pdf file, then try to add all the information into this page?

May be doable. Extract the search "query" and put/dump it into the page linked to the PDF.

@Endle
Copy link
Owner

Endle commented Feb 18, 2023

I'm working on this idea now: #114

The current dev branch should work now, would you like to have a try?

Some flaws

  1. When enabling PDF query, the performance would drop. I'll evaluate if the impact is severe.
  2. The dependency, pdf-extract, I'm not using it's main branch, so cargo package is failing, blocking me from making the next fireSeqSearch release

Endle added a commit that referenced this issue Feb 18, 2023
@Endle
Copy link
Owner

Endle commented Feb 18, 2023

@Endle Endle closed this as completed Feb 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants