added accurate mortar range circle #117
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that the mortar range circle is a fixed radius and does not account for height differences. So I have implemented a feature which makes it possible to show the accurate mortar range circle around the active mortar. The feature adds a toggle button within the "Map Settings" which lets the user decide themselves if they wanna use it or not.
It's worth mentioning that calculating the max ranges all around the mortar is fairly slow. It is done by splitting up the circle into smaller points and bearings and then test the max range. This gives a lot of points which is used to draw a polygon. I'm sure this could be done more efficiently.