Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #83
For this issue, I think it's sufficient to just stop the existing tests and any future unit tests from being bundled with the
dist/dir by babel, which is accomplished in this PR. Then runningnpm testwill only pick up the tests in theapp/dir.When we start to write test files for the backend code that need to be converted to ES5 syntax before we can test them, I think we can use the
babel-jestplugin. Either that or we can figure out how to run the tests againstdist/at that time.Check out these two links for some reading on this topic of testing
src/vsdist/with Jest