Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dependency issues #508

Merged
merged 3 commits into from
Sep 9, 2022
Merged

Conversation

trevor-crypto
Copy link
Contributor

  1. Reorganize dependencies and remove requirements ("=") on wasm-bindgen
    and js-sys, due to conflicts that can occur when using this crate.
  2. Replace wasm-bindgen's "serde-serialize" feature with
    serde-wasm-bindgen due to cyclical dependency issue.

Relates to:
tkaitchuck/aHash#95
rustwasm/wasm-bindgen#3031

1. Reorganize dependencies and remove requirements ("=") on wasm-bindgen
   and js-sys, due to conflicts that can occur when using this crate.
2. Replace wasm-bindgen's "serde-serialize" feature with
   serde-wasm-bindgen due to cyclical dependency issue.

Relates to:
tkaitchuck/aHash#95
rustwasm/wasm-bindgen#3031
@vsubhuman vsubhuman requested a review from lisicky August 26, 2022 13:13
Copy link
Contributor

@lisicky lisicky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/check

@lisicky
Copy link
Contributor

lisicky commented Sep 2, 2022

@trevor-crypto perfect PR, thanks!

@trevor-crypto
Copy link
Contributor Author

@lisicky thank you for reviewing. It appears that the failing check is warning that a pub(crate) function is unused. It is used only in a test. Should I add the #[cfg(test)] on it, or just leave it?

@lisicky
Copy link
Contributor

lisicky commented Sep 5, 2022

Thanks @trevor-crypto :) This is our problem, don't worry we will fix it.

@vsubhuman vsubhuman added this to the 11.1.0 milestone Sep 9, 2022
Copy link
Contributor

@vsubhuman vsubhuman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @trevor-crypto !

@vsubhuman vsubhuman merged commit e4ae872 into Emurgo:master Sep 9, 2022
@vsubhuman vsubhuman mentioned this pull request Sep 29, 2022
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants