Fix computed property overridability deprecation warnings (#68)

* Fix computed property overidability deprecation warnings * Update initials.js
EmberExperts · Apr 23, 2019 · b9fc6b4 · b9fc6b4
1 parent b16eb16
commit b9fc6b4
Show file tree

Hide file tree

Showing 2 changed files with 51 additions and 18 deletions.
diff --git a/addon/mixins/initials.js b/addon/mixins/initials.js
@@ -55,12 +55,24 @@ export default Mixin.create(Avatar, {
     this.notifyPropertyChange('src');
   }),
 
-  backgroundColor: computed('colors.length', 'seedText', 'defaultName', 'defaultBackground', function () {
-    if (this.get('seedText') === this.get('defaultName')) {
-      return this.get('defaultBackground');
-    } else {
-      let index = ColorIndex(this.get('seedText'), this.get('colors.length'));
-      return this.get('colors')[index];
+  backgroundColor: computed('colors.length', 'seedText', 'defaultName', 'defaultBackground', {
+    get() {
+      if (this._backgroundColor) {
+        return this._backgroundColor;
+      }
+
+      let { colors, seedText, defaultName, defaultBackground } = this;
+
+      if (seedText === defaultName) {
+        return defaultBackground;
+      } else {
+        let index = ColorIndex(seedText, colors.length);
+        return colors[index];
+      }
+    },
+
+    set(key, value) {
+      return this._backgroundColor = value;
     }
   }),
 

diff --git a/package-lock.json b/package-lock.json