This repository was archived by the owner on Oct 31, 2025. It is now read-only.
spirv-builder: pass through non-JSON stdout lines even after an error. #267
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
khyperia
approved these changes
Nov 20, 2020
Contributor
khyperia
left a comment
khyperia
left a comment
There was a problem hiding this comment.
neat, I actually repeatedly hit this and was like "but wait I thought I passed through invalid-json-stdout" but never bothered to put in the time to debug why it wasn't printing. thanks!
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While investigating #192, I couldn't get
RUSTC_LOGto work for the nested build, and it turns out that it was a combination of it outputting on stdout (which rust-lang/rust#79238 fixes) andspirv-buildernot showing any of the stdout on failure.This addresses the latter, in case a similar problem to the former, arises in the future.