This repository was archived by the owner on Oct 31, 2025. It is now read-only.
Show panic! messages via debugPrintf, even including some runtime arguments ({u,i,f}32 as {} or {:?}).#1082
Merged
eddyb merged 2 commits intoEmbarkStudios:mainfrom Jul 21, 2023
LykenSol:even-more-panic
Merged
Show panic! messages via debugPrintf, even including some runtime arguments ({u,i,f}32 as {} or {:?}).#1082eddyb merged 2 commits intoEmbarkStudios:mainfrom LykenSol:even-more-panic
panic! messages via debugPrintf, even including some runtime arguments ({u,i,f}32 as {} or {:?}).#1082eddyb merged 2 commits intoEmbarkStudios:mainfrom
LykenSol:even-more-panic
Conversation
This was referenced Jul 20, 2023
…`format_args!` removal.
… arguments (`{u,i,f}32` as `{}` or `{:?}`).
VZout
approved these changes
Jul 21, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also, this PR moves us in the direction of "preferring fewer optimizations" (we now force
-Zinline-mir=off),as that makes it easier to e.g. reliably pattern-match on the generated SPIR-V.
By adding some out of bounds indexing to the
sky-shader, and running:VK_LOADER_LAYERS_ENABLE=VK_LAYER_KHRONOS_validation VK_LAYER_ENABLES=VK_VALIDATION_FEATURE_ENABLE_DEBUG_PRINTF_EXT DEBUG_PRINTF_TO_ STDOUT=1 cargo run -p example-runner-wgpu --release -- --force-spirv-passthru, we get:Note that bounds-checking panics come from a
corefunction which happens to do:(that is, we don't special-case bounds-checking panics, and simple
Display/Debugformatting of 32-bit integers/floats, includingusize/isize, should work, and we can do a lot more in the future)TODO: changelog.