This repository was archived by the owner on Oct 31, 2025. It is now read-only.
Refactor zombie reporting to use OpSource and prepare for SPIR-T diagnostics.#1040
Merged
eddyb merged 13 commits intoEmbarkStudios:mainfrom Apr 21, 2023
LykenSol:zombie-refactor
Merged
Refactor zombie reporting to use OpSource and prepare for SPIR-T diagnostics.#1040eddyb merged 13 commits intoEmbarkStudios:mainfrom LykenSol:zombie-refactor
OpSource and prepare for SPIR-T diagnostics.#1040eddyb merged 13 commits intoEmbarkStudios:mainfrom
LykenSol:zombie-refactor
Conversation
…-early-report-zombies`.
oisyn
approved these changes
Apr 21, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR has roughly three broad stages:
OpSourceis used instead ofrustcSourceFilehashesOpSources still get stripped out out at the very end by defaultNonSemanticdebuginfo extensions) to use the paths+hashes approach in SPIR-VrustcSourceFiles can still be accurately regenerated from the paths+sourcesOpSourcemechanism might allow other tools to work well long-termcore& friends" logic to always zombie, as the errors are on average higher-quality now for zombies--no-early-report-zombies, which makes it replace the existing zombie reporting pass, i.e. the "early zombie reporting")For 2. we have this change in diagnostics:
error: Cannot memcpy dynamically sized data --> $CORE_SRC/intrinsics.rs:2460:9 | 2460 | copy(src, dst, count) | ^^^^^^^^^^^^^^^^^^^^^ | = note: Stack: core::intrinsics::copy:: ptr_copy::copy_via_raw_ptr ptr_copy::main mainerror: cannot memcpy dynamically sized data --> $CORE_SRC/intrinsics.rs:2460:9 | 2460 | copy(src, dst, count) | ^ | note: used from within `core::intrinsics::copy::` --> $CORE_SRC/intrinsics.rs:2447:21 | 2447 | pub const unsafe fn copy(src: *const T, dst: *mut T, count: usize) { | ^ note: called by `ptr_copy::copy_via_raw_ptr` --> $DIR/ptr_copy.rs:30:18 | 30 | unsafe { core::ptr::copy(src, dst, 1) } | ^ note: called by `ptr_copy::main` --> $DIR/ptr_copy.rs:35:5 | 35 | copy_via_raw_ptr(&i, o); | ^ note: called by `main` --> $DIR/ptr_copy.rs:33:1 | 33 | #[spirv(fragment)] | ^