Skip to content
This repository was archived by the owner on Oct 31, 2025. It is now read-only.

Integrate the SPIR-T qptr experiment.#1020

Merged
eddyb merged 2 commits intoEmbarkStudios:mainfrom
LykenSol:qptr-integration
Apr 21, 2023
Merged

Integrate the SPIR-T qptr experiment.#1020
eddyb merged 2 commits intoEmbarkStudios:mainfrom
LykenSol:qptr-integration

Conversation

@eddyb
Copy link
Contributor

@eddyb eddyb commented Mar 31, 2023

For more information, check out the SPIR-T PR, which has a much longer explanation:

The short version is goes something like this:

doing more (union/enum support, more flexible storage classes, PhysicalStorageBuffer, etc.)
with less (extremely untyped pointers, removing Rust-GPU's existing "storage class inference" pass)

Currently this PR allows testing replacing the old storage class inference with qptr passes, via:

RUSTGPU_CODEGEN_ARGS="--no-infer-storage-classes --spirt-passes=qptr"

@eddyb eddyb changed the title [WIP] integrate the SPIR-T qptr experiment. Integrate the SPIR-T qptr experiment. Apr 21, 2023
@eddyb eddyb marked this pull request as ready for review April 21, 2023 18:06
@eddyb eddyb requested a review from oisyn as a code owner April 21, 2023 18:06
@eddyb eddyb enabled auto-merge (rebase) April 21, 2023 18:06
@eddyb eddyb merged commit f559a6b into EmbarkStudios:main Apr 21, 2023
@eddyb eddyb deleted the qptr-integration branch April 21, 2023 18:26
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants