Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove accidental ::{{closure}} suffix from all profile_function scopes #175

Merged
merged 2 commits into from
Dec 11, 2023

Conversation

emilk
Copy link
Collaborator

@emilk emilk commented Dec 11, 2023

Checklist

  • I have read the Contributor Guide
  • I have read and agree to the Code of Conduct
  • I have added a description of my changes and why I'd like them included in the section below

Description of Changes

In #165 I inadvertently added a ::{{closure}} suffix to the name of all profile scopes created with profile_function!, somehow not noticing it until now 🤦

…scopes

I inadvertantly added this in #165,
somehow not noticing it until now 🤦
@emilk emilk force-pushed the emilk/fix-function-name-snafu branch from 1c71814 to 26bc34d Compare December 11, 2023 11:47
@emilk emilk marked this pull request as ready for review December 11, 2023 11:49
@mergify mergify bot merged commit 243a1f8 into main Dec 11, 2023
5 of 6 checks passed
@mergify mergify bot deleted the emilk/fix-function-name-snafu branch December 11, 2023 15:10
@emilk
Copy link
Collaborator Author

emilk commented Dec 11, 2023

I think I'll make a patch release of puffin with this fix since it is so annoying

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants