Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix handling of filename for keywords #18

Merged
merged 1 commit into from
Mar 11, 2024

Conversation

bwestlin
Copy link
Member

Checklist

  • I have read the Contributor Guide
  • I have read and agree to the Code of Conduct
  • I have added a description of my changes and why I'd like them included in the section below

Description of Changes

Fix filename for generated .rs file when it is names as a keyword. For example if any of the protos here https://github.com/googleapis/googleapis/tree/master/google/type is used the resulting file will be src/proto_types/google/r#type.rs which is not valid. After the changes here the file will instead be: src/proto_types/google/type.rs

Sorry, something went wrong.

@bwestlin bwestlin requested a review from MarcusGrass as a code owner March 11, 2024 17:21
@bwestlin bwestlin removed the request for review from MarcusGrass March 11, 2024 17:22
@bwestlin bwestlin merged commit d384ab6 into main Mar 11, 2024
@bwestlin bwestlin deleted the bwe/fix-filename-for-keywords branch March 12, 2024 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant