Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add RtlCaptureContext replacement #62

Merged
merged 7 commits into from
Nov 17, 2022
Merged

Conversation

Jake-Shadle
Copy link
Member

This adds a replacement for RtlCaptureContext ported from Crashpad. The implementation is put here since this crate is used by both crash-handling in this repo, as well as minidump-writer, and unfortunately the bindings for both winapi and windows-sys are currently...broken. Neither of them properly align the CONTEXT structures on x86_64/aarch64, which can cause crashes and is just generally uhhh, not good. Since we already have replacments for getcontext on Linux it made sense to put it here. Additionally, unlike RtlCaptureContext, the x86_64 (though not aarch64) implementation captures floating point and vector state as well.

@Jake-Shadle Jake-Shadle merged commit 11fc5c9 into main Nov 17, 2022
@Jake-Shadle Jake-Shadle deleted the crash-context/impl-context branch November 17, 2022 12:57
This was referenced Nov 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant