fix(bans): report checksums for denied build scripts - #880
Merged
Jake-Shadle merged 3 commits intoJul 9, 2026
Conversation
Constraint: cargo-deny diagnostics need to expose the actual custom-build target path and hash so users can write bypass entries for non-default build scripts.\nRejected: matching only the generated build-script-build target name | non-default build scripts use names like build-script-main in cargo metadata.\nConfidence: high\nScope-risk: narrow\nDirective: Keep build script target discovery based on TargetKind::CustomBuild rather than generated target names.\nTested: cargo test shows_non_default_build_script_checksum --test bans_build -- --nocapture; cargo test --test bans_build -- --nocapture; cargo fmt --all -- --check; cargo clippy --all-targets -- -D warnings\nNot-tested: full test suite
Jake-Shadle
force-pushed
the
fix-build-script-deny-checksum
branch
from
July 9, 2026 16:09
a839300 to
740309d
Compare
Jake-Shadle
approved these changes
Jul 9, 2026
|
Tick the box to add this pull request to the merge queue (same as
|
This was referenced Jul 9, 2026
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
custom-buildtarget kind instead of a generated target name.build-script-not-alloweddiagnostics.Why
Non-default build scripts are named from their file stem in cargo metadata, e.g.
build-script-main, so matching onlybuild-script-buildskipped the build script path. That left #765 without the hash needed for a bypass entry.Fixes #765.
Validation
cargo test shows_non_default_build_script_checksum --test bans_build -- --nocapture- failed before the fix, passed aftercargo test --test bans_build -- --nocapture- passedcargo fmt --all -- --check- passedcargo clippy --all-targets -- -D warnings- passed