feat(cli): persist-smoke verb + fail-loud duplicate plugin names - #3
Merged
Conversation
added 2 commits
July 20, 2026 19:20
Adds `hermes persist-smoke`, an operator-facing smoke test that discovers plugins, asserts pre_persist_write is registered as a required hook (distinguishing no-plugin-discovered from plugin-present-but-stale), then routes a probe write through governed_persist and confirms it comes back genuinely staged rather than silently falling through to a canonical write (cleaning up the probe file on that ungoverned outcome). Also hardens plugin discovery (hermes_cli/plugins.py) so two directories declaring the same manifest name no longer let directory-iteration order silently pick a winner: a collision on a plugins.required name aborts startup naming both directories, an optional collision refuses to load either copy and logs one loud warning naming both directories, and unique names are unaffected.
|
Bugbot is not enabled for your account, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Hardening items #1 + NousResearch#4 from the post-cutover assessment (companion to agent-lineage PR NousResearch#22):
hermes persist-smoke [--json]— white-box deployment gate: discovers plugins, assertspre_persist_writein the required-hook registry with a stale-plugin-vs-no-plugin diagnosis, stages a real probe throughgoverned_persist, and judges honestly — genuine staged (empty message) ⇒ green; decision-less local fallback ⇒ red (local_fallback); denied ⇒ red; passthrough ⇒ red with probe cleanup; discovery errors ⇒ valid-JSONdiscovery-faileddiagnostic instead of a traceback. Per-run unique session ids prevent budget self-exhaustion under periodic use.plugins.requiredplugin aborts startup naming both directories BEFORE any registration; optional collisions load neither copy with one loud warning; cross-source override behavior byte-identical. The exact v0.2.0-backup-shadowing incident from the persistence cutover is now a structural startup error.Verification
🤖 Generated with Claude Code