Hack solution for aggregator recursive parts list #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When trying to bridge composed devices (devices which functionality is spread hierarchically over multiple endpoints) the aggregator needs to know all endpoints including all children of all aggregated devices. Normally we should use the `SetFlatCompositionForEndpoint` for this purpose, yet this doesn't work as the endpoint needs to be deactivated before setting the flat composition (recursive look up of children endpoints). Therefore we tell the system that all endpoints are flat composition. This will become a problem when we have composed devices of multiple depths levels. In that case we need to set thos devices to tree composition or reset tree composition to the default and find a solution how to set flat composition for the aggregator device type
dbahrdt
approved these changes
Jan 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When trying to bridge composed devices (devices which functionality is spread hierarchically over multiple endpoints) the aggregator needs to know all endpoints including all children of all aggregated devices.
Normally we should use the
SetFlatCompositionForEndpointfor this purpose, yet this doesn't work as the endpoint needs to be deactivated before setting the flat composition (recursive look up of children endpoints).Therefore we tell the system that all endpoints are flat composition.
This will become a problem when we have composed devices of multiple depths levels. In that case we need to set thos devices to tree composition or reset tree composition to the default and find a solution how to set flat composition for the aggregator device type