-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for R4.3 and new QWT version #86
Draft
marmarek
wants to merge
8
commits into
ElliotKillick:master
Choose a base branch
from
marmarek:r4.3
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
No chages are needed just due to Qubes version difference.
New QWT version doesn't require reboot after installation. Support both approaches. Technically, the new version doesn't need wait-for-shutdown.bat either, but also it's harmless (since prepare-volume.exe is gone) so keep it for old QWT version support.
New QWT requires testsigning for basic Xen PV drivers too. At least for now.
Win10 seems to work, seamless mode is properly enabled too. Win11 install does not work, due to hardware requirements. This will require either some magic in the answers xml file, or adjusting emulated hardware in qubes. |
Do not require UEFI Secure Boot and TPM. While technically they can be provided, they don't add much value in virtualized environment. QubesOS/qubes-issues#1861
12244fd
to
cdd85e5
Compare
While bypassing disk size check in Win11 makes sense in some cases, some may still want to use larger disk. It's easier to do before installation, than resize it later.
Win11 refuses to install without separate "system reserved" partition, so add that. Partitioning with DiskConfiguration in Win11 is unreliable/broken. Either results in no partitions created at all, or a layout that isn't accepted by the installer. Follow what https://schneegans.de/windows/unattend-generator/ (and various other examples) do and use diskpart.exe. QubesOS/qubes-issues#1861
On Win11, AppActivate doesn't work reliably, sometimes it requires manually clicking on the "Windows Security" window. According to the documentation[1] (for VBA not VBS... but I haven't found VBS's AppActivate docs), there is a second argument "wait" - whether to wait for the calling application to get focus first. Documentation says the default is False, but it behaves like it actually is True. Set it explicitly to False (0), which fixes the issue. [1] https://learn.microsoft.com/en-us/office/vba/Language/Reference/user-interface-help/appactivate-statement QubesOS/qubes-issues#1861
FWIW the last commit isn't sufficient: https://openqa.qubes-os.org/tests/133554#step/windows_install/26 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is lightly tested on Win10 pro, more tests are coming.
See individual commit messages for details.