Skip to content

[Fix] zero param check #164

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yhna940 merged 1 commit into from
Mar 28, 2023
Merged

[Fix] zero param check #164

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 13 additions & 5 deletions oslo/torch/nn/parallel/data_parallel/zero/sharded_optim/_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,6 @@
from oslo.torch.distributed import ParallelMode


# TODO
def is_model_parallel_parameter(p: torch.Tensor) -> bool:
"""
Check if a parameter is parallel in either Pipeline or Tensor mode.
Expand All @@ -34,10 +33,19 @@ def is_model_parallel_parameter(p: torch.Tensor) -> bool:
Returns:
bool: True if the parameter is parallel in either mode, False otherwise.
"""
parallel_mode = getattr(p, "oslo_parallel", {})
return ParallelMode.PIPELINE in parallel_mode or any(
key.startswith("tensor") for key in parallel_mode
)
oslo_parallel = getattr(p, "oslo_parallel", {})
parallel_modes = [
ParallelMode.PIPELINE,
ParallelMode.TENSOR_1D,
ParallelMode.TENSOR_2D_ROW,
ParallelMode.TENSOR_2D_COL,
ParallelMode.TENSOR_2P5D_ROW,
ParallelMode.TENSOR_2P5D_COL,
ParallelMode.TENSOR_2P5D_DEP,
ParallelMode.TENSOR_3D_INPUT,
ParallelMode.TENSOR_3D_OUTPUT,
]
return any(mode in oslo_parallel for mode in parallel_modes)


def flatten(input_: Iterable[torch.Tensor]) -> torch.Tensor:
Expand Down