Merged
Conversation
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
|
|
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
Contributor
Author
|
Is anyone available to review this? |
Contributor
|
cc @baberabb |
Contributor
Author
|
Bump |
Contributor
|
Thanks for the ping, and sorry I missed this earlier. Tested and everything looks good. Merging! |
JessicaOjo
pushed a commit
to JessicaOjo/lm-evaluation-harness
that referenced
this pull request
Dec 10, 2025
* Update vLLM compatibility Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk> * add TokensPrompt to all generate calls --------- Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk> Co-authored-by: Baber <baber@hey.com>
JessicaOjo
pushed a commit
to JessicaOjo/lm-evaluation-harness
that referenced
this pull request
Dec 10, 2025
* Update vLLM compatibility Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk> * add TokensPrompt to all generate calls --------- Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk> Co-authored-by: Baber <baber@hey.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolve_hf_chat_templatevllm-project/vllm#18259, so the workaround in [Fix] Updateresolve_hf_chat_templatearguments #2992 is no longer needed.llm.generatecall to work with [Deprecation] Removeprompt_token_idsarg fallback inLLM.generateandLLM.embedvllm-project/vllm#18800cc @fxmarty-amd @baberabb