Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[sizing] fixes and enhancements #26

Merged
merged 10 commits into from
Feb 16, 2024
Merged

[sizing] fixes and enhancements #26

merged 10 commits into from
Feb 16, 2024

Conversation

stas00
Copy link
Collaborator

@stas00 stas00 commented Feb 15, 2024

This PR:

  1. fixes:
  File "/data/stas/benchmarks/cookbook/benchmarks/sizing/mm_flops.py", line 47, in <module>
    with open(args.output_file, 'w') as sys.stdout:
FileNotFoundError: [Errno 2] No such file or directory: '../results/mm.out'

now you can launch the script from any relative dir and it'd just work.

  1. adds dependencies needed to run the scripts

  2. adds --verbose (default On) and a Tee class to send print to both log file and stdout

  3. adds a useful note+link about https://gist.github.com/malfet/6a17156d7f5663b8b12054a1beff3fe1 that @Quentin-Anthony shared with me.


Questions:

  1. results probably shouldn't be under git

@CLAassistant
Copy link

CLAassistant commented Feb 15, 2024

CLA assistant check
All committers have signed the CLA.

@stas00 stas00 marked this pull request as ready for review February 16, 2024 02:17
Copy link
Member

@Quentin-Anthony Quentin-Anthony left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!!

@Quentin-Anthony Quentin-Anthony merged commit 3d3011e into main Feb 16, 2024
1 check passed
@stas00 stas00 deleted the fixes branch February 17, 2024 06:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants