Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the the SLURM launcher in two ways:
self.args.slurm_comment
was still referenced, and the launcher would include--comment
even whenself.args.comment
was an empty string.--account
rather than--comment
for assigning accounting groups to a given job. (if this is too specific to the Stability cluster, happy to find some way to allow users to toggle between using--account
and--comment
I've left the
comment
argument in GPT-NeoX with its same name, but can update it to something likeslurm_account
if that is preferred.cc @Quentin-Anthony