Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker refactoring #3

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Dim0N22
Copy link

@Dim0N22 Dim0N22 commented Mar 28, 2021

This PR is related to PR#2 in ElementumOrg/cross-compiler.
It introduces a couple of improvements:

  • Unified image tags (elementumorg/cross-compiler:base instead of cross-compiler:base)
  • Dockerfile uses multistage builds to improve performance and minimize resulting image
  • Library versions can be changed independently without affecting others. For example changing boost version won't trigger rebuid for swig.
  • If you use Docker 18.09+, you can set DOCKER_BUILDKIT=1 to build multiple indepdendent stages in parallel. This further improves build speed

I've tested it and successfully built libtorrent for android-arm.
This is a draft PR but I want to work on all other images as well.
Let me know what you think.

@Dim0N22 Dim0N22 marked this pull request as draft March 28, 2021 03:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant