Bookkeeper migration part 1: the cleanups#8445

Merged

rustyrussell merged 29 commits intoElementsProject:masterfrom

rustyrussell:bkpr-part1

Aug 14, 2025

Commits on Aug 14, 2025

pytest: save pre-movement dbs, and accounting dbs.
rustyrussell
committed
db: better diagnostics when a query fails.
rustyrussell
committed
libplugin: make jsonrpc_set_datastore_binary() take an explicit length.
rustyrussell
committed
onchaind: don't consider our anchors to be payments into the wallet.
rustyrussell
committed
common: remove "ignored" tag.
rustyrussell
committed
db: hand amount_msat / amount_sat by copy, not pointer.
rustyrussell
committed
lightningd: use channel_coin_mvt / chain_coin_mvt directly for notifications.
rustyrussell
committed
common: remove `struct coin_mvt` altogether.
rustyrussell
committed
common/coin_mvt: make more parameters const.
rustyrussell
committed
common: coin movements for payments need group id as well as part id.
rustyrussell
committed
common/coin_mvt: use enum rather than true/false for credit/debit.
rustyrussell
committed
common/coin_mvt: add struct mvt_account_id to separate channels from others.
rustyrussell
committed
common/coin_mvt: make more fields const, reorder fields.
rustyrussell
committed
common: rename enum mvt_tag values.
rustyrussell
committed
pytest: don't assume that tags will always be in the same order.
rustyrussell
committed
common: enforce the use of a "primary" tag in coin_mvt tags.
rustyrussell
committed
common: mvt_tag_strs() function to turn tags array into strings.
rustyrussell
committed
common: mvt_tag parsing routine.
rustyrussell
committed
coin_mvt: use bitmap instead of tal_arr for tags.
rustyrussell
committed
common: implement primary_mvt_tag() to extract primary tag.
rustyrussell
committed
lightningd: separate coin_movement `tags` array into `primary_tag` and `extra_tags`.
rustyrussell
committed
coin_mvt: put timestamp into the struct.
rustyrussell
committed
common: make chain_coin_mvt's outpoint member a non-pointer.
rustyrussell
committed
lightningd: extract core of coin_movement notification, for use in list functions.
rustyrussell
committed
common: put "external" and "wallet" strings, and test functions into common/coin_mvt.h
rustyrussell
committed
bkpr: remove unused "account_exits" parameter to account_get_balance().
rustyrussell
committed
bkpr: remove currency support from balances.
rustyrussell
committed
bkpr: remove different currency support.
rustyrussell
committed
lightningd: have onchaind inform us when to make a channel penalty_adj.
rustyrussell
committed