implementation HTLC Endorsement to Mitigate Channel Jamming#6714
implementation HTLC Endorsement to Mitigate Channel Jamming#6714vincenzopalazzo wants to merge 4 commits intoElementsProject:masterfrom
Conversation
vincenzopalazzo
force-pushed
the
macros/jamming-mitigation-change
branch
from
ec3a3d2 to
e399424
Compare
vincenzopalazzo
added
the
protocol
vincenzopalazzo
force-pushed
the
macros/jamming-mitigation-change
branch
2 times, most recently
from
1818598 to
d15c4c8
Compare
vincenzopalazzo
force-pushed
the
macros/jamming-mitigation-change
branch
from
d15c4c8 to
554241e
Compare
vincenzopalazzo
force-pushed
the
macros/jamming-mitigation-change
branch
from
0f5fb2b to
a7eb48a
Compare
vincenzopalazzo
force-pushed
the
macros/jamming-mitigation-change
branch
5 times, most recently
from
bb2cbaf to
3cbaac7
Compare
vincenzopalazzo
force-pushed
the
macros/jamming-mitigation-change
branch
2 times, most recently
from
3982077 to
ffa7580
Compare
|
This is quite minimal, but it includes the essential work needed to start addressing the channel mitigation issue. Additionally, I believe it should support modifying the value of |
vincenzopalazzo
force-pushed
the
macros/jamming-mitigation-change
branch
from
ffa7580 to
0178a29
Compare
rustyrussell
left a comment
rustyrussell
left a comment
There was a problem hiding this comment.
Looks intersesting, but not for this release, since it doesn't actually do any endorsement :)
I agree that it does not make a lot of sense to put this inside this release, not because we do not have any endorsement, but because I do not have tested it and I do not know if we need another hook or the current one is fine. For endorsement currently, we need to implement the reputation and look at it, so I am planning to share the implementation done by Carla inside the https://github.com/LNOpenMetrics/go-lnmetrics.reporter before implementing it inside the cln builtin plugins I know that you have an opinion on the way that how the metrics should be, so I will move incremental step before putting an effort into implementing it in C |
This commit introduce the wire change to the wire sysytem of core lightning in order to implement the [1]. [1] lightning/bolts#1071 Signed-off-by: Vincenzo Palazzo <vincenzopalazzodev@gmail.com>
vincenzopalazzo
force-pushed
the
macros/jamming-mitigation-change
branch
4 times, most recently
from
7a75b2d to
4249cb9
Compare
This comment was marked as outdated.
This comment was marked as outdated.
vincenzopalazzo
requested review from
cdecker and
rustyrussell
and removed request for
nepet
vincenzopalazzo
force-pushed
the
macros/jamming-mitigation-change
branch
3 times, most recently
from
6edb5d5 to
5882f09
Compare
Changelog-Experimental: minimal peer to peer support for the channel jamming mitigation Signed-off-by: Vincenzo Palazzo <vincenzopalazzodev@gmail.com>
Passing down to the plugins the endorsed value, using the htlc_accepted hook. Allow plugins to modify it, but I think we should have a way to limit what kind of plugins can modify the following value. This is left as a open question. Signed-off-by: Vincenzo Palazzo <vincenzopalazzodev@gmail.com>
Signed-off-by: Vincenzo Palazzo <vincenzopalazzodev@gmail.com>
vincenzopalazzo
force-pushed
the
macros/jamming-mitigation-change
branch
from
5882f09 to
42609ca
Compare
|
Ok this is better that will go in the next release there is something that I need to do |
|
Ok i need to rework this, I would like to take another approach |
3 participants
Implementation of lightning/bolts#1071
The only thing is that that I think that the hook should be under and
experimental flag