Weekly cleanups #3636
Merged
Weekly cleanups #3636
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
niftynei
reviewed
Apr 8, 2020
niftynei
reviewed
Apr 8, 2020
rustyrussell
approved these changes
Apr 9, 2020
So far we've always cleared the node directory when provisioning the node, but while testing some plugins we noticed that pre-generating some files in that directory is useful. This just adds yet another flag to `get_node` that disables deleting any existing node directory.
While we removed the `satoshi` param in ElementsProject#3603 it appears that the `fundchannel` plugin was still passing it to the `fundchannel_start` call. This fixes up the help text. Notice that technically the help text changes the param name, but since it was internally always called `amount` this change doesn't break the API, the help was just wrong.
|
ACK fab8ad6 |
|
missing changelog for bolt decoding change? |
The spec states that invoices with an amount, but lacking a multiplier, should be interpreted as integer Bitcoin amounts: `amount`: optional number in that currency, followed by an optional `multiplier` letter. The unit encoded here is the 'social' convention of a payment unit -- in the case of Bitcoin the unit is 'bitcoin' NOT satoshis. Suggested-by: Stefano Pellegrini <@St333p> Signed-off-by: Christian Decker <@cdecker> Changelog-Fixed: invoice: The invoice parser assumed that an amount without a multiplier was denominated in msatoshi instead of bitcoins.
I was told that DSNs are not trivial to format, so this adds an example to help setup the postgres wallet backend.
|
Added changelog for the bolt11 fix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
node_factory(needed by some plugins that prepare the node directory before the node first starts, e.g., the backup plugin dropping abackup.lockfile so the backend is ensured to stay the same).satoshiparameter from thefundchannel_startdocs