Update BOLT11 test vectors, strengthen implementation. #3481
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This next test will have route hints. Signed-off-by: Rusty Russell <[email protected]>
See-also: lightning/bolts#699 Signed-off-by: Rusty Russell <[email protected]>
As tested in next test. Signed-off-by: Rusty Russell <[email protected]>
See-also: lightning/bolts#736 Signed-off-by: Rusty Russell <[email protected]>
Otherwise you can ask for a sub-millisatoshi amount, which is dumb and violates the spec. See-also: lightning/bolts#736 Signed-off-by: Rusty Russell <[email protected]> Changelog-Changed: We now reject invoices which ask for sub-millisatoshi amounts
cdecker
reviewed
Feb 3, 2020
common/bolt11.c
Outdated
Comment on lines
393
to
400
| } else { | ||
| /* Restore version for unknown field! */ | ||
| (*data)--; | ||
| (*data_len)++; | ||
| data_length++; | ||
| return unknown_field(b11, hu5, data, data_len, 'f', | ||
| data_length); | ||
| } |
There was a problem hiding this comment.
Yes, I didn't fix current code. Will append a whitespace patch though
Didn't generally fixup inside comments and the bech32 code: reformatting that is just anti-social. Signed-off-by: Rusty Russell <[email protected]>
|
ACK a253e8a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These new test vectors are proposed in the spec at lightning/bolts#736 but the improvements stand on their own anyway.