Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

libplugin: use json stream helpers and add sanity tests #3480

Merged
merged 10 commits into from
Feb 9, 2020
Merged

libplugin: use json stream helpers and add sanity tests #3480

merged 10 commits into from
Feb 9, 2020

Commits on Feb 5, 2020

  1. libplugin: expose helpers to start and end a jsonrpc response 

    The usual json_stream starters and command_result enders.
    @darosior
    darosior committed Feb 5, 2020
    Configuration menu
    Copy the full SHA
    ff0bfba View commit details
    Browse the repository at this point in the history

  2. libplugin: use json_stream helpers for handle_getmanifest

    @darosior
    darosior committed Feb 5, 2020
    Configuration menu
    Copy the full SHA
    60e3c77 View commit details
    Browse the repository at this point in the history

  3. libplugin: use json_stream helpers for RPC calls 

    This adds helpers to start and send a jsonrpc request using json_stream
in order to benefit from the helpers.

This then simplifies existing plugins RPC requests by using json_stream
helpers.
    @darosior
    darosior committed Feb 5, 2020
    Configuration menu
    Copy the full SHA
    15a2986 View commit details
    Browse the repository at this point in the history

  4. libplugin: use json_stream for all plugins' commands

    @darosior
    darosior committed Feb 5, 2020
    Configuration menu
    Copy the full SHA
    9205764 View commit details
    Browse the repository at this point in the history

  5. pytest: add a C testing plugin to test libplugin 

    We mark the test as xfail() as it exposes that libplugin's PLUGIN_RESTARTABLE
was not taken into account !
    @darosior
    darosior committed Feb 5, 2020
    Configuration menu
    Copy the full SHA
    bd18dd1 View commit details
    Browse the repository at this point in the history

  6. libplugin: fix 'dynamic' field in getmanifest 

    As a separated commit because it was pre-existent (changelog + xfail test).

This also fix a logical problem in lightningd/plugin_control: we were
assuming a plugin started with 'plugin start' but which did not comport
a 'dynamic' entry in its manifest to be dynamic, though it should have
been treated as static.

Changelog-fixed: plugins: Dynamic C plugins can now be managed when lightningd is up
    @darosior
    darosior committed Feb 5, 2020
    Configuration menu
    Copy the full SHA
    f9c198a View commit details
    Browse the repository at this point in the history

  7. pytest: test hooks and notifications with libplugin

    @darosior
    darosior committed Feb 5, 2020
    Configuration menu
    Copy the full SHA
    25521ea View commit details
    Browse the repository at this point in the history

  8. pytest: test libplugin's send_outreq

    @darosior
    darosior committed Feb 5, 2020
    Configuration menu
    Copy the full SHA
    b86c84d View commit details
    Browse the repository at this point in the history

  9. ccan: retrieve last updates to opt/ 

    Co-authored-by: Rusty Russell <[email protected]>
    @darosior @rustyrussell
    darosior and rustyrussell committed Feb 5, 2020
    Configuration menu
    Copy the full SHA
    3692159 View commit details
    Browse the repository at this point in the history

  10. lightningd/plugin: unregister a plugin's options when stopping it 

    This also remove the now duplicate plugin_hook_unregister_all(), added
in the tal destructor of the struct plugin.
    @darosior
    darosior committed Feb 5, 2020
    Configuration menu
    Copy the full SHA
    77e7f0f View commit details
    Browse the repository at this point in the history