Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check that the createonion arguments don't exceed the onion payload size #3404

Merged
merged 3 commits into from
Jan 10, 2020
Merged

Check that the createonion arguments don't exceed the onion payload size #3404

merged 3 commits into from
Jan 10, 2020

Conversation

cdecker
Copy link
Member

@cdecker cdecker commented Jan 8, 2020

Fixes #3377

@cdecker cdecker added this to the 0.8.1 milestone Jan 8, 2020
ZmnSCPxj
ZmnSCPxj reviewed Jan 9, 2020
View reviewed changes
Copy link
Collaborator

@ZmnSCPxj ZmnSCPxj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code is fine, but the error returned by JSON-RPC... we should really strongly deprecate LIGHTNINGD error codes.

lightningd/pay.c Outdated Show resolved Hide resolved
ZmnSCPxj
ZmnSCPxj approved these changes Jan 9, 2020
View reviewed changes
Copy link
Collaborator

@ZmnSCPxj ZmnSCPxj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 8f1d56b

@cdecker cdecker merged commit 5e44895 into ElementsProject:master Jan 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZmnSCPxj ZmnSCPxj ZmnSCPxj approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.8.1
2 participants
@cdecker @ZmnSCPxj