txprepare fixes #3384
Merged
txprepare fixes #3384
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add test for empty args check
adds (currently failing test) for a txprepare with more than two outputs
The number of outputs got updated, but the map used to calculate the change output's location did not (still assumes only one output). This patch fixes this to make the output map a variable size. Changelog-Fixed: JSON API: `txprepare` no longer crashes when more than two outputs are specified
niftynei
force-pushed
the
nifty/txprepare_fixes
branch
from
68c94fc
to
7f59865
Compare
|
ACK 7f59865 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes two crashes/bugs I found in
txprepare:txpreparein keywords mode inpyln-clientwould crash (fails an check for what version of the API you're using)