Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fundchannel connect #3314

Merged

Conversation

niftynei
Copy link
Collaborator

@niftynei niftynei commented Dec 4, 2019

supercedes #3307

still unclear to me what cases you can reconnect to a peer without their IP address, however.

darosior and others added 3 commits December 4, 2019 12:50
Changelog-Added: RPC: The 'fundchannel' command now tries to connect to the peer before funding the channel, no need to 'connect' before 'fundchannel' anymore !
Attempts to connect to peer before funding the channel
@darosior
Copy link
Collaborator

darosior commented Dec 4, 2019

still unclear to me what cases you can reconnect to a peer without their IP address, however.

@cdecker's seed ;-)

Copy link
Collaborator

@darosior darosior left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 9d9d8b6

If you prefer to drop my first commit if it's cleaner, i dont care :)

@niftynei niftynei merged commit a30ee2b into ElementsProject:master Dec 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants