devtools/onion: fixed argument passing for generate and decode methods #3250
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devtools/onion.c
Outdated
| @@ -109,7 +109,7 @@ static void do_generate(int argc, char **argv, | |||
| u8 *serialized = serialize_onionpacket(ctx, res); | |||
| if (!serialized) | |||
| errx(1, "Error serializing message."); | |||
| printf("%s\n", tal_hex(ctx, serialized)); | |||
| printf("%s", tal_hex(ctx, serialized)); | |||
There was a problem hiding this comment.
Hmm, this is a bit awkward if you run it on the cmdline though?
Can we instead fix it up on the input side?
There was a problem hiding this comment.
Good point; I've rebased to leave the trailing newline but instead trim whitespace with 6a078de . Is this better?
|
Nice work! |
|
Thanks! and ht to @willcl-ark for the testing that lead to these fixes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed 'generate' and 'decode' methods to properly parse argv arguments.
Fixed so methods correctly use the associated data set by the --assoc-data flag.
I also added some examples to -h to better show how these methods work with real onion data.
Introduced a behavioral change to read the onion from a file instead of stdin; this makes it easier to debug in some IDEs (eg. vscode).