Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gossipd: fixes for experimental crcs and query flags #2999

Merged
merged 3 commits into from
Aug 27, 2019
Merged

gossipd: fixes for experimental crcs and query flags #2999

merged 3 commits into from
Aug 27, 2019

Commits on Aug 27, 2019

  1. gossipd: fix calculation of crc32 of update. 

    Currently EXPERIMENTAL_FEATURES only, fortunately.

Signed-off-by: Rusty Russell <[email protected]>
    @rustyrussell
    rustyrussell committed Aug 27, 2019
    Configuration menu
    Copy the full SHA
    0a40e0f View commit details
    Browse the repository at this point in the history

  2. gossipd: test crc32 routines using test vectors from PR. 

    Signed-off-by: Rusty Russell <[email protected]>
    @rustyrussell
    rustyrussell committed Aug 27, 2019
    Configuration menu
    Copy the full SHA
    4e36651 View commit details
    Browse the repository at this point in the history

  3. gossipd: fix gossip send in case query_flags cause no output. 

    Fortunately, again, only happens with EXPERIMENTAL_FEATURES.

If the query causes us not to actually send anything, we won't
get called again.  This can validly happen if they only asked for
the node_announcements, for example.

(Found by protocol tests).

Signed-off-by: Rusty Russell <[email protected]>
    @rustyrussell
    rustyrussell committed Aug 27, 2019
    Configuration menu
    Copy the full SHA
    b5d0c09 View commit details
    Browse the repository at this point in the history