Skip to content

test_lightningd.py: Enable bech32 test for DEVELOPER#1127

Closed
jsarenik wants to merge 3 commits intoElementsProject:masterfrom
jsarenik:jasan/bech32_test
Closed

test_lightningd.py: Enable bech32 test for DEVELOPER#1127
jsarenik wants to merge 3 commits intoElementsProject:masterfrom
jsarenik:jasan/bech32_test

Conversation

@jsarenik
Copy link
Contributor

Since bitcoind 0.16 is already released it is safe to enable
this test already.

@jsarenik
Copy link
Contributor Author

@cdecker could you please update docker image cdecker/lightning-ci to install bitcoind 0.16 in order for the bech32 test to pass? Thank you.

@rustyrussell
Copy link
Contributor

Please also remove the 432-block check in test_lightning.py too: we now only need to generate 100 blocks (to get some funds to spend). Might speed up tests a little, too.

Since bitcoind 0.16 is already released it is safe to enable
this test already.
Rusty wrote at #1127
On Tue, Feb 27, 2018 at 19:51:06 +0000 (UTC):
> Please also remove the 432-block check in test_lightning.py
> too: we now only need to generate 100 blocks (to get some funds
> to spend). Might speed up tests a little, too.
Uses BITCOIN_VERSION ENV variable in the beggining of Dockerfile.
@cdecker
Copy link
Member

cdecker commented Feb 28, 2018

We have a bit of an overlap with #1134 now. 100 blocks isn't sufficient since we need at least one coinbase to be mature to be able to do anything. We also need to fix a few tests that rely on a specific blockchain height.

@cdecker
Copy link
Member

cdecker commented Feb 28, 2018

I cherry-picked your first commit onto #1134, so this now is completely superseded by it 😉
Cherry-picking will still give you credit for your commit though, which is important to me 😃

@jsarenik
Copy link
Contributor Author

@cdecker Thanks! :)

@jsarenik
Copy link
Contributor Author

@cdecker @rustyrussell Closing this pull request in favor of #1134 - though I would like to be included in further discussion regarding 100 blocks...

@jsarenik jsarenik closed this Feb 28, 2018
@jsarenik jsarenik deleted the jasan/bech32_test branch March 1, 2018 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants