test_lightningd.py: Enable bech32 test for DEVELOPER#1127
test_lightningd.py: Enable bech32 test for DEVELOPER#1127jsarenik wants to merge 3 commits intoElementsProject:masterfrom jsarenik:jasan/bech32_test
Conversation
|
@cdecker could you please update docker image |
|
Please also remove the 432-block check in test_lightning.py too: we now only need to generate 100 blocks (to get some funds to spend). Might speed up tests a little, too. |
Since bitcoind 0.16 is already released it is safe to enable this test already.
Rusty wrote at #1127 On Tue, Feb 27, 2018 at 19:51:06 +0000 (UTC): > Please also remove the 432-block check in test_lightning.py > too: we now only need to generate 100 blocks (to get some funds > to spend). Might speed up tests a little, too.
Uses BITCOIN_VERSION ENV variable in the beggining of Dockerfile.
|
We have a bit of an overlap with #1134 now. 100 blocks isn't sufficient since we need at least one coinbase to be mature to be able to do anything. We also need to fix a few tests that rely on a specific blockchain height. |
|
I cherry-picked your first commit onto #1134, so this now is completely superseded by it 😉 |
|
@cdecker Thanks! :) |
|
@cdecker @rustyrussell Closing this pull request in favor of #1134 - though I would like to be included in further discussion regarding 100 blocks... |
Since bitcoind 0.16 is already released it is safe to enable
this test already.